Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase spacy maximum version #146

Merged
merged 2 commits into from
Oct 9, 2021
Merged

Increase spacy maximum version #146

merged 2 commits into from
Oct 9, 2021

Conversation

Zethson
Copy link
Contributor

@Zethson Zethson commented Oct 9, 2021

fixes #145

(Testing at the moment -> will edit if it works). pip takes forever to resolve the dependencies...

edit 1: Running for more then 4 hours already. The resolver is so slow, it's incredible....

Finally resolves building with typer 0.4 and therefore click 8.x
@Zethson Zethson marked this pull request as ready for review October 9, 2021 20:21
@Zethson
Copy link
Contributor Author

Zethson commented Oct 9, 2021

@w-is-h Built for hours with the new pip resolver, but worked out in the end. It installs the new typer (0.4.0) and therefore works with click 8.x

I would appreciate a swift patch release. I hope that I will not run into more conflicts later :)
Cannot really test them because mixing local setuptools installed packages with Poetry is a mess.

Thank you very much for your fast response!

@w-is-h
Copy link
Collaborator

w-is-h commented Oct 9, 2021

@Zethson Strange, my build went through in seconds

@w-is-h w-is-h merged commit 97b84d0 into CogStack:master Oct 9, 2021
mart-r pushed a commit to mart-r/MedCAT that referenced this pull request Jun 14, 2023
Increase spacy maximum version
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Upgrade SpaCy dependencies
2 participants